only call sizeof on isbits types
#275
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meggart
reviewed
Sep 15, 2025
| @@ -62,15 +62,20 @@ function common_chunks(s, args...) | |||
| all(ar -> isa(eachchunk(ar), GridChunks), chunkedarrays) || | |||
| error("Currently only chunks of type GridChunks can be merged by broadcast") | |||
| if isempty(chunkedarrays) | |||
| totalsize = sum(sizeof ∘ eltype, args) | |||
| return estimate_chunksize(s, totalsize) | |||
There was a problem hiding this comment.
I think this function does actually the wrong thing. Can we just call into this method
Line 441 in 877fd67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently fails for
String, and will for any other non-isbits typeThis PR adds another path for non-isbits types in broadcast that just treats the whole array as one chunk.
Closes #261